Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sky Island] Death EoC cures modded conditions too #78644

Merged
merged 6 commits into from
Dec 20, 2024
Merged

[Sky Island] Death EoC cures modded conditions too #78644

merged 6 commits into from
Dec 20, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Dec 18, 2024 •
edited
Loading

Summary

Mods "[Sky Island] Death EoC cures modded conditions too"

Purpose of change

It's important that you don't get suck in a death loop due to mods.

Describe the solution

Add EoCs for Magiclysm, Mind Over Matter, and Xedra Evolved that run when you die and clear common conditions from those mods. Magiclysm runs a Disjunction on you (should remove all magical buffs and debuffs), MoM one sets Nether Attunement to 0 and clears all Nether Attunement and power overload effects, and the XE one gives you ruach (if you're a lilit and don't have enough), blood (if you're a vampire and don't have enough), and removes fae ban effects, goblin spiders, dread weight, and the evil eye.

These EoCs are empty dummy EoCs that do nothing if you run without the mods in question. They're overriden in the mod_interactions folders.

Describe alternatives you've considered

Testing

Got killed on the island, made sure the EoCs fired.

Additional context

I was going to do some of this for the statue heal but there's a comment there that it should only heal HP so I didn't.

@Standing-Storm Standing-Storm marked this pull request as draft December 18, 2024 15:52
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Sky Island Anything about the Sky Island mod astyled astyled PR, label is assigned by github actions labels Dec 18, 2024
@SariusSkelrets
Copy link
Contributor

Giving a little less than a day of ruach would keep lilin from abusing the ruach restoration to max their power gain odds.

Currently the player could wait for their ruach to drop to zero, drop all their stuff to the ground, die, get resurrected, instantly spend all their ruach for upgrades then repeat over and over, reducing the power gain process to a death loop.

@Standing-Storm
Copy link
Contributor Author

Currently the player could wait for their ruach to drop to zero, drop all their stuff to the ground, die, get resurrected, instantly spend all their ruach for upgrades then repeat over and over, reducing the power gain process to a death loop.

Hmm. It's probably better to just lock them out of spending ruach to gain powers for a couple days after they die--a day might not be enough time to fully recover from a death if you're out of warp shards

@github-actions GitHub Actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Your ruach is too fragile to spend it frivilously.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 19, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review December 19, 2024 18:26
@Maleclypse Maleclypse merged commit b9000a6 into CleverRaven:master Dec 20, 2024
28 of 38 checks passed
@Standing-Storm Standing-Storm deleted the sky-island-cure-conditions branch December 21, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Standing-Storm @SariusSkelrets @Maleclypse